feat(transpile): Support fixed length lists#1315
feat(transpile): Support fixed length lists#1315vados-cosmonic merged 3 commits intobytecodealliance:mainfrom
Conversation
6c8bd13 to
6e1c631
Compare
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Excellent work @yannbolliger -- I only had incredibly minor nits, and am happy to merge this as soon as those are addressed.
|
Ah also @yannbolliger we require conventional commits here (I think that's the only test failing), so here are some commit titles that would be good: (for a commit with all the bindgen changes) (for a commit with the changes made to jco test and the rust test components I can make these changes for you if you'd like! |
Oh, I thought we were squashing the commits at the end and this only applied to the PR. 👍 |
a7c7765 to
2d427a2
Compare
|
As weird as this sounds, the cc-commits check does not like capital letters to start the commit title: |
Head branch was pushed to by a user without write access
2d427a2 to
584e963
Compare
Closes #1240
Adds support for Fixed Length Lists to the transpile.
The (likely wrong) implementations for Fixed Length Lists of
gen_flat_lower_fn_js_exprandgen_flat_lower_fn_list_js_exprhave not been changed.