Skip to content

Update use jco directive to use components#1410

Merged
vados-cosmonic merged 2 commits intobytecodealliance:mainfrom
alexcrichton:jco
Apr 17, 2026
Merged

Update use jco directive to use components#1410
vados-cosmonic merged 2 commits intobytecodealliance:mainfrom
alexcrichton:jco

Conversation

@alexcrichton
Copy link
Copy Markdown
Member

This is a small change to the use jco directive intended to be used for telemetry to make this less tool-specific and instead leave open the opportunity for other projects to use this as well which may not be using jco specifically.

@alexcrichton
Copy link
Copy Markdown
Member Author

I'll note as well that this is under the assumption that this telemetry isn't actually hooked up anywhere yet. If it is, this'll be a bit more difficult to change!

cc @lukewagner on this as well

Copy link
Copy Markdown
Collaborator

@vados-cosmonic vados-cosmonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

As far as this possibly being elsewhere (and in use), I'm not against just having both :)

@vados-cosmonic
Copy link
Copy Markdown
Collaborator

We're quite strict on commit titles, so to save you some time, the below message should work (mostly refactor(bindgen) and ensuring not to use a capital case letter after : ):

refactor(bindgen): update 'use jco' directive to 'use components'

As silly as it sounds, it would be ideal if we split up the change to test/jco into another commit so it's picked up cleanly by the automation:

test(jco): update directive test to check for 'use components'

@lukewagner
Copy link
Copy Markdown

Seems reasonable to me too

vados-cosmonic and others added 2 commits April 18, 2026 05:39
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Co-authored-by: Alex Crichton <alex@alexcrichton.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com>
Co-authored-by: Alex Crichton <alex@alexcrichton.com>
@vados-cosmonic vados-cosmonic added this pull request to the merge queue Apr 17, 2026
Merged via the queue into bytecodealliance:main with commit 4af8b1a Apr 17, 2026
37 checks passed
@alexcrichton alexcrichton deleted the jco branch April 17, 2026 21:51
@alexcrichton
Copy link
Copy Markdown
Member Author

Thanks @vados-cosmonic!

@jco-release-bot
Copy link
Copy Markdown
Collaborator

jco-release-bot commented Apr 18, 2026

🎉 The code in this PR was made available in the following release:
https://github.com/bytecodealliance/jco/releases/tag/jco-v1.18.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants