Update use jco directive to use components#1410
Update use jco directive to use components#1410vados-cosmonic merged 2 commits intobytecodealliance:mainfrom
use jco directive to use components#1410Conversation
|
I'll note as well that this is under the assumption that this telemetry isn't actually hooked up anywhere yet. If it is, this'll be a bit more difficult to change! cc @lukewagner on this as well |
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
As far as this possibly being elsewhere (and in use), I'm not against just having both :)
|
We're quite strict on commit titles, so to save you some time, the below message should work (mostly As silly as it sounds, it would be ideal if we split up the change to |
|
Seems reasonable to me too |
Signed-off-by: Victor Adossi <vadossi@cosmonic.com> Co-authored-by: Alex Crichton <alex@alexcrichton.com>
Signed-off-by: Victor Adossi <vadossi@cosmonic.com> Co-authored-by: Alex Crichton <alex@alexcrichton.com>
|
Thanks @vados-cosmonic! |
|
🎉 The code in this PR was made available in the following release: |
This is a small change to the
use jcodirective intended to be used for telemetry to make this less tool-specific and instead leave open the opportunity for other projects to use this as well which may not be using jco specifically.