fix(bindgen): use waitable index in p3 future event payload#1433
Merged
vados-cosmonic merged 1 commit intobytecodealliance:mainfrom Apr 29, 2026
Merged
Conversation
vados-cosmonic
approved these changes
Apr 29, 2026
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thanks for the fix!
Merged
via the queue into
bytecodealliance:main
with commit Apr 29, 2026
f075523
96 of 109 checks passed
Collaborator
|
🎉 The code in this PR was made available in the following release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The producer side of
future.read/future.writeis emittingcomponentIdxas the event'spayload0, but that value identifies the component instance and not the specific future so a wasm task waiting on multiple futures couldn't tell which oneresolved.