fix(bindgen): populate imported resource lower metadata#1450
Merged
Conversation
vados-cosmonic
approved these changes
May 6, 2026
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Thanks for fixing this bit of the metadata (it's as bit messy to have both those lookups, I know!)
andreiltd
force-pushed
the
fix/import-res-meta
branch
from
7342e43 to
4236e44
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failure shows up with async imports that return resources inside result, for example filesystem ops like this:
throws:
Basically
imports_resource_typesmaps WIT type id to the runtime resource type. But the lowering forown<T>needs the reverse mapping: given the concrete resource type, find the WIT resource type id so it can generate correct func.