Skip to content

fix(p2-shim): ip dns lookup mapping return#1453

Merged
vados-cosmonic merged 1 commit into
mainfrom
fix(p2-shim)=ip-lookup-mapping
May 8, 2026
Merged

fix(p2-shim): ip dns lookup mapping return#1453
vados-cosmonic merged 1 commit into
mainfrom
fix(p2-shim)=ip-lookup-mapping

Conversation

@vados-cosmonic
Copy link
Copy Markdown
Collaborator

resolves #1451

resolves #1451

Signed-off-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
@vados-cosmonic
Copy link
Copy Markdown
Collaborator Author

vados-cosmonic commented May 8, 2026

What's left here is to add a regression test to make sure this stays fixed/doesn't break in the future.

[EDIT] - We don't have many tests that explore socket functionality (outside of the excellent tests in p3-shim) -- so it might be worth adding a new Rust component to test the shim and call resolve-addresses to exercise this shim path:

static _resolveAddresses(network, name) {

@vados-cosmonic
Copy link
Copy Markdown
Collaborator Author

Failure on MacOS is not actually related to changes here:

dlopen /Users/runner/.cache/puppeteer/chrome/mac_arm-139.0.7258.68/chrome-mac-arm64/Google Chrome for Testing.app/Contents/MacOS/../Frameworks/Google Chrome for Testing Framework.framework/Versions/139.0.7258.68/Google Chrome for Testing Framework: dlopen(/Users/runner/.cache/puppeteer/chrome/mac_arm-139.0.7258.68/chrome-mac-arm64/Google Chrome for Testing.app/Contents/MacOS/../Frameworks/Google Chrome for Testing Framework.framework/Versions/139.0.7258.68/Google Chrome for Testing Framework, 0x0105): tried: '/Users/runner/.cache/puppeteer/chrome/mac_arm-139.0.7258.68/chrome-mac-arm64/Google Chrome for Testing.app/Contents/MacOS/../Frameworks/Google Chrome for Testing Framework.framework/Versions/139.0.7258.68/Google Chrome for Testing Framework' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/Users/runner/.cache/puppeteer/chrome/mac_arm-139.0.7258.68/chrome-mac-arm64/Google Chrome for Testing.app/Contents/MacOS/../Frameworks/Google Chrome for Testing Framework.framework/Versions/139.0.7258.68/Google Chrome for Testing Framework' (no such file), '/Users/runner/.cache/puppeteer/chrome/mac_arm-139.0.7258.68/chrome-mac-arm64/Google Chrome for Testing.app/Contents/MacOS/../Frameworks/Google Chrome for Testing Framework.framework/Versions/139.0.7258.68/Google Chrome for Testing Framework' (no such file).

Other platforms are testing OK, so going to merge this now that the follow up to add a regression test has been created

@vados-cosmonic vados-cosmonic merged commit 8fad097 into main May 8, 2026
32 of 37 checks passed
@vados-cosmonic vados-cosmonic deleted the fix(p2-shim)=ip-lookup-mapping branch May 8, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: IP Name lookup in preview2-shim sockets broken

1 participant