fix(p2-shim): ip dns lookup mapping return#1453
Merged
Merged
Conversation
resolves #1451 Signed-off-by: Victor Adossi <123968127+vados-cosmonic@users.noreply.github.com>
Collaborator
Author
|
What's left here is to add a regression test to make sure this stays fixed/doesn't break in the future. [EDIT] - We don't have many tests that explore socket functionality (outside of the excellent tests in p3-shim) -- so it might be worth adding a new Rust component to test the shim and call |
Collaborator
Author
|
Failure on MacOS is not actually related to changes here: Other platforms are testing OK, so going to merge this now that the follow up to add a regression test has been created |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1451