fix(bindgen): fix result rejection lowering and stream drop propagation#1461
Merged
vados-cosmonic merged 1 commit intoMay 12, 2026
Conversation
andreiltd
changed the title
Collaborator
|
Test is still going to fail but this will be rebased and merge soon (after the other waiting PRs!) |
Member
Author
|
Thanks! Yes, I will keep an eye on CI fix and rebase all the PRs when it lands. |
vados-cosmonic
force-pushed
the
fix/p3-bindgen-stream-future-lifecycle
branch
from
295aac2 to
07e8453
Compare
This patch contains a few fixes: - fix typo in realloc callback - rejected future<result<>> are converted to result.err - write to a dropped stream should return DROPPED - forward shim dispose to canonical stream end
vados-cosmonic
force-pushed
the
fix/p3-bindgen-stream-future-lifecycle
branch
from
07e8453 to
5e46968
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch contains a few fixes:
future<result<>>are converted toresult.errDROPPED