Skip to content

fix(bindgen)!: make canon opts optional for func bindgen#1488

Merged
vados-cosmonic merged 1 commit into
bytecodealliance:mainfrom
vados-cosmonic:fix(bindgen)=make-canon-opts-optional-for-func-bindgen
May 15, 2026
Merged

fix(bindgen)!: make canon opts optional for func bindgen#1488
vados-cosmonic merged 1 commit into
bytecodealliance:mainfrom
vados-cosmonic:fix(bindgen)=make-canon-opts-optional-for-func-bindgen

Conversation

@vados-cosmonic
Copy link
Copy Markdown
Collaborator

This commit makes breaking changes to FunctionBindgen, making canon_opts optional in cases where the user of the generator

While this breaking change would normally cause a major version bump, since the functionality has actually been broken since 1.11.0 (!) due o missing exported configuration objects, we take this change to use a builder for FunctionBindgen itself and introduce non exhaustiveness for related configuration structs as well via bon.

@vados-cosmonic vados-cosmonic requested a review from andreiltd as a code owner May 15, 2026 02:58
This commit makes breaking changes to `FunctionBindgen`, making
canon_opts optional in cases where the user of the generator

While this breaking change would normally cause a major version bump,
since the functionality has actually been broken since 1.11.0 (!) due
o missing exported configuration objects, we take this change to use a
builder for `FunctionBindgen` itself and introduce non exhaustiveness
for related configuration structs as well via `bon`.
@vados-cosmonic vados-cosmonic force-pushed the fix(bindgen)=make-canon-opts-optional-for-func-bindgen branch from 1cea9df to f945134 Compare May 15, 2026 05:27
@vados-cosmonic vados-cosmonic enabled auto-merge May 15, 2026 05:27
@vados-cosmonic vados-cosmonic added this pull request to the merge queue May 15, 2026
Merged via the queue into bytecodealliance:main with commit b954e41 May 15, 2026
40 checks passed
@vados-cosmonic vados-cosmonic deleted the fix(bindgen)=make-canon-opts-optional-for-func-bindgen branch May 15, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant