fix(bindgen): use builder for TranspileOpts#1490
Merged
vados-cosmonic merged 1 commit intoMay 15, 2026
Merged
Conversation
This commit introduces yet another breaking change into an already-broken API -- `TranspileOpts` -- to ensure that it can be used a bit more easily going forward. Since `TranspileOpts` is used in other parts of the codebase, namely `transpile(..)`, it was very disruptive to make it non exhaustive, so it will be left with `pub` members to avoid unnecessary disruption of downstream consumers.
Merged
via the queue into
bytecodealliance:main
with commit May 15, 2026
1210795
77 of 79 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces yet another breaking change into an already-broken API --
TranspileOpts-- to ensure that it can be used a bit more easily going forward.Since
TranspileOptsis used in other parts of the codebase, namelytranspile(..), it was very disruptive to make it non exhaustive, so it will be left withpubmembers to avoid unnecessary disruption of downstream consumers.