refactor(bindgen): remove usage of _FN_LOCALS#1500
Merged
vados-cosmonic merged 1 commit intoMay 16, 2026
Merged
Conversation
This commit removes `_FN_LOCALS` as it is likely too cumbersome for downstream users -- instead `FunctionBindgen` has a new parameter (which can be ignored) which contains the information that component processing would normally provide that processing for certain instructions needs. With this approach, downstream users may build a `FunctionBindgen` object as normal, and get reasonable/expected values (or control values explicitly), *without* performing full processing of a component.
vados-cosmonic
force-pushed
the
fix(bindgen)=fix-usages-of-fn-locals
branch
from
011bb72 to
96711f6
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes
_FN_LOCALSas it is likely too cumbersome for downstream users -- insteadFunctionBindgenhas a new parameter (which can be ignored) which contains the information that component processing would normally provide that processing for certain instructions needs.With this approach, downstream users may build a
FunctionBindgenobject as normal, and get reasonable/expected values (or control values explicitly), without performing full processing of a component.