fix(bindgen): lift imported own handles via captureTable#1515
Merged
Conversation
vados-cosmonic
previously approved these changes
May 20, 2026
Collaborator
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LTGM 🚀
One readability nit but otherwise good to go!
This fixes issue with p3 http handlers throwing:
ReferenceError: finalizationRegistry{N} is not defined
For `InterfaceType::Own` lift, but `ensure_resource_table` only declares
`finalizationRegistry{tid}` for guest defined resources and imported
resources are tracked by `captureTable{rid}` instead. The pathc just
mirrors the logic for `Instruction::HandleLift` from function_bindgen.rs
file.
andreiltd
force-pushed
the
fix/import-handles
branch
from
29c5a7d to
4525ed7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue with p3 http handlers throwing:
For
InterfaceType::Ownliftensure_resource_tableonly declaresfinalizationRegistry{tid}for guest defined resources and imported resources are tracked bycaptureTable{rid}instead. The pathc just mirrors the logic forInstruction::HandleLiftfrom function_bindgen.rs file.