fix(bindgen): issue with lifting resources#1572
Merged
vados-cosmonic merged 4 commits intoMay 29, 2026
Merged
Conversation
Collaborator
Author
|
The combined component that serves as a regression test is a 18MB binary (C++ component composed with a Python component), so a follow up PR will introduce machinery for building those components and a separate extended test suite will be created. |
This commit fixes resource origination tracking (i.e. figuring out where a resource was created) that was used when deciding how to borrow a given resource -- the previous code did not work for composed components, and did not/could not properly track inter-component transfers.
vados-cosmonic
force-pushed
the
fix(bindgen)=issue-with-lifting-resources
branch
from
1aafe7c to
59f605d
Compare
vados-cosmonic
force-pushed
the
fix(bindgen)=issue-with-lifting-resources
branch
from
39d6aa2 to
7b48a80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1380
This PR also likely resolves other related reports around the same time, but I have not yet confirmed, only this one has been reproduced and fixed.