feat(p3-shim): implement wasi preview3 nodejs filesystem API#724
Conversation
vados-cosmonic
force-pushed
the
p3-filesystem
branch
from
b3ef306 to
ba1678e
Compare
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
Thanks for the hard work here @andreiltd and splitting it off to make it easier to review!
andreiltd
force-pushed
the
p3-filesystem
branch
3 times, most recently
from
7594d29 to
8798626
Compare
vados-cosmonic
left a comment
vados-cosmonic
left a comment
There was a problem hiding this comment.
LGTM 🚀
Some minor comments but this should be ready to merge after they're resolved!
| @@ -0,0 +1,185 @@ | |||
| export class StreamReader { | |||
There was a problem hiding this comment.
That link isn't working, but I think we should be consistent here -- if you need to expose the reader and writer classes, then that's fine! I value the consistency of them being public or not.
IMO if you'd like to have a constructor that allows for a different implementation of the streams to be sent in, then could be a separate function people can call (or other options to the future()/stream() functions). That said, I'm fine either way here -- let's make them (consistently) public for now, we've bikeshed on this long enough, probably.
Head branch was pushed to by a user without write access
vados-cosmonic
changed the title
vados-cosmonic
changed the title
2 participants
Split from: #653