Skip to content

fix(p3-shim): avoid side effects when loading filesystem API #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vados-cosmonic merged 2 commits into from
Jun 6, 2025
Merged

fix(p3-shim): avoid side effects when loading filesystem API #738

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d4b3b0
fix(p3-shim): avoid side effects when loading filesystem API
andreiltd Jun 6, 2025
dbe8ea6
Merge branch 'main' into p3-filesystem
andreiltd Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions packages/preview3-shim/lib/nodejs/filesystem/descriptor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,12 @@ import { wasiTypeFromDirent } from './utils.js';

const symbolDispose = Symbol.dispose || Symbol.for('dispose');

const _worker = new ResourceWorker(
new URL('../workers/filesystem-worker.js', import.meta.url)
);
let WORKER = null;
function worker() {
return (WORKER ??= new ResourceWorker(
new URL('../workers/filesystem-worker.js', import.meta.url)
));
}

class Descriptor {
/** Node.js file handle for file operations (FileHandle from fs.promises.open) */
Expand Down Expand Up @@ -99,7 +102,7 @@ class Descriptor {
readViaStream(offset) {
this.#ensureHandle();
const transform = new TransformStream();
const promise = _worker
const promise = worker()
.run(
{
op: 'read',
Expand Down Expand Up @@ -137,7 +140,7 @@ class Descriptor {
const stream = await data.intoReadableStream();

try {
await _worker.run(
await worker().run(
{ op: 'write', fd: this.#handle.fd, offset, stream },
[stream]
);
Expand Down Expand Up @@ -327,7 +330,7 @@ class Descriptor {
);

const transform = new TransformStream();
const promise = _worker
const promise = worker()
.run(
{
op: 'readDir',
Expand Down
Loading