Skip to content
This repository was archived by the owner on Mar 24, 2022. It is now read-only.

Add support for small(er) Docker images to use (not work on) Lucet#201

Merged
jedisct1 merged 3 commits intomasterfrom
fdenis/lucet-toolchain
Jun 12, 2019
Merged

Add support for small(er) Docker images to use (not work on) Lucet#201
jedisct1 merged 3 commits intomasterfrom
fdenis/lucet-toolchain

Conversation

@jedisct1
Copy link
Copy Markdown
Contributor

@jedisct1 jedisct1 commented Jun 7, 2019

This adds the ability to build a new Docker image, lucet-toolchain, that only contains the Lucet toolchain, and not the boilerplate to build it.

Lucet tools can then be directly used as:

docker run --rm lucet-toolchain lucet-wasi ...

This image is based on the current Ubuntu, and uses the stock LLVM installation, so it can be used as a base image for projects willing to build upon Lucet.

@pchickey
Copy link
Copy Markdown
Contributor

pchickey commented Jun 7, 2019

I like this, but it doesn't look like it gets used from CI at all, so we'd be depending on user reports if it bit rots and breaks. Is there a sensible way to test it with travis?

@jedisct1
Copy link
Copy Markdown
Contributor Author

jedisct1 commented Jun 7, 2019

I can add this to Travis, but as this is going to make the builds take more time to complete, we will get closer to the point where Travis will explode.

But let's try :)

@pchickey
Copy link
Copy Markdown
Contributor

Ok. If this is the straw that breaks Travis's back, we can merge it without CI. Thanks for giving it a try. Hopefully we wont be on Travis for too much longer.

jedisct1 added 3 commits June 10, 2019 22:16
Building the toolchain in release mode is too slow for CI.
So, introduce an `install-dev` target, that reuses the debug build.

The overhead is reasonable.
@jedisct1 jedisct1 force-pushed the fdenis/lucet-toolchain branch from 222815c to b497e62 Compare June 10, 2019 20:21
@jedisct1
Copy link
Copy Markdown
Contributor Author

Some changes have been added to the Travis builds. We now build the lucet container (not just lucet-dev) as well as the lucet-toolchain one.

Just like in non-CI mode, except that what gets installed is the binaries compiled in debug mode. When the same scripts are run outside CI, they are still compiled in release mode.

@jedisct1 jedisct1 merged commit 3f04ef0 into master Jun 12, 2019
@jedisct1 jedisct1 deleted the fdenis/lucet-toolchain branch June 12, 2019 08:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants