This repository was archived by the owner on Oct 4, 2022. It is now read-only.
A few memory enhancements #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The manual implementation of clone was not efficient, since it would cause a lot of resizes of the underlying set structure. There's already an efficient Clone implementation for FxHashSet, so use that instead.
This removes the need for one vector entirely by flushing range fragment creation when they're ready, instead of waiting up to the end. It also reuses a Map across block iterations, instead of creating one that's resized over time.
…s as inputs; The data-flow analysis ensures later on that there are no duplicates in these lists, so the user doesn't have to worry about this, and thus can pass plain slices for all of these.
bnjbvr
force-pushed
the
memory-enhancements
branch
from
e38eb03 to
793bd1a
Compare
julian-seward1
approved these changes
Jun 2, 2020
| // Sets of things | ||
|
|
||
| // Same comment as above for FxHashMap. | ||
| #[derive(Clone)] |
Contributor
There was a problem hiding this comment.
Umm, yes. Now I wonder why I didn't do this to begin with :-)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits reduce the number of memory allocations during compilation with Cranelift:
Each commit has been tested for performance separately and did improve all the metrics (icount, number of malloc'd bytes and blocks), when tested on joey-big/joey-medium/regex-rs.wasm test cases. For the latter, it's a 9% icount decrease, 19% block allocations decrease, 10% total of allocated bytes decrease.