Merged
Conversation
Return move edits from `resolve_inserted_moves` instead of eagerly allocating that vector in `Env`.
cfallin
approved these changes
Jun 12, 2023
|
|
||
| Ok(Output { | ||
| edits: env | ||
| edits: edits |
Member
There was a problem hiding this comment.
If we wanted to clean up just a bit more, we could add a method around this iterator chain on Edits (into_... or something). Happy to skip if you'd prefer not to though.
Member
Author
There was a problem hiding this comment.
I moved the iterator chain into a method that consumes self, and I think it cleaned things up nicely. Thanks for the suggestion!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return move edits from
resolve_inserted_movesinstead of eagerly allocating that vector inEnv.