Make Ioctl::opcode a method instead of a constant#1286
Merged
sunfishcode merged 1 commit intobytecodealliance:mainfrom Jan 25, 2025
Merged
Make Ioctl::opcode a method instead of a constant#1286sunfishcode merged 1 commit intobytecodealliance:mainfrom
sunfishcode merged 1 commit intobytecodealliance:mainfrom
Conversation
50ece82 to
588aaca
Compare
588aaca to
0df7462
Compare
Member
|
This looks reasonable to me. @notgull do you have any thoughts on |
Contributor
|
This should be fine. I mistakenly believed that the opcode was always a constant and that const evaluation could fill in what gaps there were. |
Member
|
Thanks! |
This was referenced Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This lets the
Ioctltrait be compatible with ioctls that take a runtime length value, e.g. these evdev ioctls frominput.h:These generally specify the length of the passed buffer, so that the driver can copy data into userspace (à la
read()).rg 'len\)\s*_IO' /usr/includegives 26 results on my system, so they're not rare, and it'd be great to be able to use theIoctltrait to wrap them.Prior art:
nix::ioctl_read_buf!()