Add a new ReturnFlags type for flags returned from recvmsg#1288
Merged
sunfishcode merged 10 commits intomainfrom Jan 30, 2025
Merged
Add a new ReturnFlags type for flags returned from recvmsg#1288sunfishcode merged 10 commits intomainfrom
ReturnFlags type for flags returned from recvmsg#1288sunfishcode merged 10 commits intomainfrom
Conversation
sunfishcode
force-pushed
the
sunfishcode/return-flags
branch
from
b0c0afa to
c5bbdd6
Compare
`RecvMsgReturn`'s `flags` field was previously `RecvFlags`, however `recvmsg` returns a different set of flags than that. To address that, add a new type, `ReturnFlags`, which contains the flags that are returned from `recvmsg`. Fixes #1287.
- Disable `RecvFlags::TRUNC` on Apple. - Check for `AF_UNIX` socket addresses with no paths on Apple.
sunfishcode
force-pushed
the
sunfishcode/return-flags
branch
from
c5bbdd6 to
18753ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RecvMsgReturn'sflagsfield was previouslyRecvFlags, howeverrecvmsgreturns a different set of flags than that. To address that, add a new type,ReturnFlags, which contains the flags that are returned fromrecvmsg.Fixes #1287.