Support SIGRTMIN+n signals.#1292
Merged
sunfishcode merged 10 commits intomainfrom Jan 28, 2025
Merged
Conversation
Change `Signal` from an `enum` to a `struct` wrapper around an `i32` so that it can accomodate values it doesn't know about statically, and add APIs for constructing and working with `SIGRTMIN+n` signal values. This requires making `Signal::from_raw` depend on a new "use-libc-sigrt" feature, as it depends on being able to call into libc. This also adds `Signal::from_raw_unchecked` which does not call into libc and is unsafe. Fixes #1249.
sunfishcode
added
the
semver bump
Member
|
This looks great, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Signalfrom anenumto astructwrapper around ani32so that it can accomodate values it doesn't know about statically, and add APIs for constructing and working withSIGRTMIN+nsignal values.This requires making
Signal::from_rawdepend on a new "use-libc-sigrt" feature, as it depends on being able to call into libc. This also addsSignal::from_raw_uncheckedwhich does not call into libc and is unsafe.Fixes #1249.