Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -398,3 +398,6 @@ mod timespec;
all(linux_kernel, feature = "net")
))]
mod ugid;

#[cfg(doc)]
pub mod not_implemented;
317 changes: 317 additions & 0 deletions src/not_implemented.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,317 @@
//! Unimplemented functions.
//!
//! This module contains documentation for several functions that rustix does
//! not implement, either because they are out of scope, or because they are
//! could probably be implemented but are not yet.

macro_rules! not_implemented {
($func:ident) => {
/// See the [module comment](self).
pub fn $func() {
unimplemented!()
}
};
}

/// Memory-allocation functions are out of scope for rustix.
///
/// It is possible to implement `malloc`, `free`, and similar functions in
/// Rust, however rustix itself is focused on syscall-like functions. This
/// module contains an incomplete list of such functions.
///
/// There are several allocator implementations for Rust; one of them is
/// [dlmalloc]. For a rustix-based implementation, see [rustix-dlmalloc].
/// Another allocator implementaion is [talc].
///
/// [dlmalloc]: https://crates.io/crates/dlmalloc
/// [talc]: https://crates.io/crates/talc
/// [rustix-dlmalloc]: https://github.com/sunfishcode/rustix-dlmalloc
pub mod memory_allocation {
Comment thread
sunfishcode marked this conversation as resolved.
not_implemented!(malloc);
not_implemented!(realloc);
not_implemented!(calloc);
not_implemented!(free);
not_implemented!(posix_memalign);
not_implemented!(aligned_alloc);
not_implemented!(malloc_usable_size);
}

/// Functions which need access to libc internals are out of scope for rustix.
///
/// Most Rust programs have a libc present, and when a libc is present, it
/// expects to be the only thing in the process that can do certain operations.
/// For example, there can be only one `atexit` list in a process, only one
/// `pthread_atfork` list in a process, only one implementation of pthreads in
/// a process, and so on, and libc expects to own the one of each of those
/// things. And libc implementations may expect to be involved in signal
/// handling. So, these functions are believed to be out of scope for rustix.
/// This module contains an incomplete list of such functions.
///
/// It would be possible to make a rust library which provides safe or
/// ergonomic wrappers around these libc functions, however that is out of
/// scope for rustix itself.
///
/// If you would like to write a Rust program which does not use a libc, and
/// which does provide APIs for some of these functions, [Eyra] and [origin]
/// are two libraries which may be useful, and which provide public interfaces
/// for some of this functionality.
///
/// If you are otherwise writing Rust code which you know will not share a
/// process with a libc, perhaps because you are writing a libc or similar
/// yourself, rustix's codebase does include experimental implementations of
/// the primitives needed to implement most of these functions.
///
/// [Eyra]: https://github.com/sunfishcode/eyra?tab=readme-ov-file#eyra
/// [origin]: https://github.com/sunfishcode/origin?tab=readme-ov-file#origin
pub mod libc_internals {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is incomplete - most obviously, there are a lot more pthread functions, and I think there are also more groups of kernel primitives that the C library needs to be intimately involved in any use of, e.g. rseq. It might be better to just say that it's incomplete rather than to try to make it exhaustive.

It's really unfortunate that pthreads implementations for Linux tend to interpose on the signal handling API. As far as I know, C libraries for other kernels do not need to do this. Not having full access to the signal handling API (and the fork/exec API) is a significant hindrance for projects like CLI shells; I think rustix's approach to those ideally ought to be that it calls into libc when configured to use libc as a back end, and makes direct system calls when not so configured.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is incomplete - most obviously, there are a lot more pthread functions, and I think there are also more groups of kernel primitives that the C library needs to be intimately involved in any use of, e.g. rseq. It might be better to just say that it's incomplete rather than to try to make it exhaustive.

The list is for people searching for specific names. So I've gone ahead and added all the pthread_* functions and rseq, and also added a comment saying it's not exhaustive.

It's really unfortunate that pthreads implementations for Linux tend to interpose on the signal handling API. As far as I know, C libraries for other kernels do not need to do this. Not having full access to the signal handling API (and the fork/exec API) is a significant hindrance for projects like CLI shells; I think rustix's approach to those ideally ought to be that it calls into libc when configured to use libc as a back end, and makes direct system calls when not so configured.

I think CLI shells can do everything they need using the public libc APIs to signals and fork/exec. If you want wrappers providing better ergonomics, that could be a separate library. If you don't want to use an actual libc and want direct syscalls, then origin and eyra are where the party's at.

not_implemented!(exit);
not_implemented!(fork);
not_implemented!(brk);
not_implemented!(sigaction);
not_implemented!(sigaltstack);
not_implemented!(sigprocmask);
not_implemented!(sigwait);
not_implemented!(sigwaitinfo);
not_implemented!(sigtimedwait);
not_implemented!(set_thread_area);
not_implemented!(set_tid_address);
not_implemented!(tkill);
not_implemented!(sched_setscheduler);
not_implemented!(rseq);

not_implemented!(pthread_atfork);
not_implemented!(pthread_attr_destroy);
not_implemented!(pthread_attr_getaffinity_np);
not_implemented!(pthread_attr_getdetachstate);
not_implemented!(pthread_attr_getguardsize);
not_implemented!(pthread_attr_getinheritsched);
not_implemented!(pthread_attr_getschedparam);
not_implemented!(pthread_attr_getschedpolicy);
not_implemented!(pthread_attr_getscope);
not_implemented!(pthread_attr_getsigmask_np);
not_implemented!(pthread_attr_getstack);
not_implemented!(pthread_attr_getstackaddr);
not_implemented!(pthread_attr_getstacksize);
not_implemented!(pthread_attr_init);
not_implemented!(pthread_attr_setaffinity_np);
not_implemented!(pthread_attr_setdetachstate);
not_implemented!(pthread_attr_setguardsize);
not_implemented!(pthread_attr_setinheritsched);
not_implemented!(pthread_attr_setschedparam);
not_implemented!(pthread_attr_setschedpolicy);
not_implemented!(pthread_attr_setscope);
not_implemented!(pthread_attr_setsigmask_np);
not_implemented!(pthread_attr_setstack);
not_implemented!(pthread_attr_setstackaddr);
not_implemented!(pthread_attr_setstacksize);
not_implemented!(pthread_barrierattr_destroy);
not_implemented!(pthread_barrierattr_getpshared);
not_implemented!(pthread_barrierattr_init);
not_implemented!(pthread_barrierattr_setpshared);
not_implemented!(pthread_barrier_destroy);
not_implemented!(pthread_barrier_wait);
not_implemented!(pthread_cancel);
not_implemented!(pthread_cleanup_pop);
not_implemented!(pthread_cleanup_pop_restore_np);
not_implemented!(pthread_cleanup_push);
not_implemented!(pthread_cleanup_push_defer_np);
not_implemented!(pthread_condattr_destroy);
not_implemented!(pthread_condattr_getclock);
not_implemented!(pthread_condattr_getpshared);
not_implemented!(pthread_condattr_init);
not_implemented!(pthread_condattr_setclock);
not_implemented!(pthread_condattr_setpshared);
not_implemented!(pthread_cond_broadcast);
not_implemented!(pthread_cond_destroy);
not_implemented!(pthread_cond_signal);
not_implemented!(pthread_cond_timedwait);
not_implemented!(pthread_create);
not_implemented!(pthread_detach);
not_implemented!(pthread_equal);
not_implemented!(pthread_exit);
not_implemented!(pthread_getaffinity_np);
not_implemented!(pthread_getattr_default_np);
not_implemented!(pthread_getattr_np);
not_implemented!(pthread_getconcurrency);
not_implemented!(pthread_getcpuclockid);
not_implemented!(pthread_getname_np);
not_implemented!(pthread_getschedparam);
not_implemented!(pthread_getspecific);
not_implemented!(pthread_join);
not_implemented!(pthread_key_create);
not_implemented!(pthread_key_delete);
not_implemented!(pthread_kill);
not_implemented!(pthread_kill_other_threads_np);
not_implemented!(pthread_mutexattr_destroy);
not_implemented!(pthread_mutexattr_getprioceiling);
not_implemented!(pthread_mutexattr_getprotocol);
not_implemented!(pthread_mutexattr_getpshared);
not_implemented!(pthread_mutexattr_getrobust);
not_implemented!(pthread_mutexattr_getrobust_np);
not_implemented!(pthread_mutexattr_gettype);
not_implemented!(pthread_mutexattr_init);
not_implemented!(pthread_mutexattr_setprioceiling);
not_implemented!(pthread_mutexattr_setprotocol);
not_implemented!(pthread_mutexattr_setpshared);
not_implemented!(pthread_mutexattr_setrobust);
not_implemented!(pthread_mutexattr_setrobust_np);
not_implemented!(pthread_mutexattr_settype);
not_implemented!(pthread_mutex_consistent);
not_implemented!(pthread_mutex_consistent_np);
not_implemented!(pthread_mutex_destroy);
not_implemented!(pthread_mutex_getprioceiling);
not_implemented!(pthread_mutex_init);
not_implemented!(pthread_mutex_lock);
not_implemented!(pthread_mutex_setprioceiling);
not_implemented!(pthread_mutex_timedlock);
not_implemented!(pthread_mutex_trylock);
not_implemented!(pthread_once);
not_implemented!(pthread_rwlockattr_destroy);
not_implemented!(pthread_rwlockattr_getkind_np);
not_implemented!(pthread_rwlockattr_getpshared);
not_implemented!(pthread_rwlockattr_init);
not_implemented!(pthread_rwlockattr_setkind_np);
not_implemented!(pthread_rwlockattr_setpshared);
not_implemented!(pthread_rwlock_destroy);
not_implemented!(pthread_rwlock_rdlock);
not_implemented!(pthread_rwlock_timedrdlock);
not_implemented!(pthread_rwlock_timedwrlock);
not_implemented!(pthread_rwlock_tryrdlock);
not_implemented!(pthread_rwlock_trywrlock);
not_implemented!(pthread_rwlock_unlock);
not_implemented!(pthread_rwlock_wrlock);
not_implemented!(pthread_self);
not_implemented!(pthread_setaffinity_np);
not_implemented!(pthread_setattr_default_np);
not_implemented!(pthread_setcancelstate);
not_implemented!(pthread_setcanceltype);
not_implemented!(pthread_setconcurrency);
not_implemented!(pthread_setname_np);
not_implemented!(pthread_setschedparam);
not_implemented!(pthread_setschedprio);
not_implemented!(pthread_setspecific);
not_implemented!(pthread_sigmask);
not_implemented!(pthread_sigqueue);
not_implemented!(pthread_spin_destroy);
not_implemented!(pthread_spin_init);
not_implemented!(pthread_spin_lock);
not_implemented!(pthread_spin_trylock);
not_implemented!(pthread_spin_unlock);
not_implemented!(pthread_testcancel);
not_implemented!(pthread_timedjoin_np);
not_implemented!(pthread_tryjoin_np);
not_implemented!(pthread_yield);
}

/// Functions which provide higher-level functionality are out of scope for
/// rustix.
///
/// These functions are provided by typical libc implementations, but are
/// higher-level than the simple syscall-like functions that rustix focuses
/// on. They could be implemented as a separate library built on top of rustix,
/// rather than being part of rustix itself. This module contains an incomplete
/// list of such functions.
pub mod higher_level {
not_implemented!(getpwent);
not_implemented!(getpwuid);
not_implemented!(getpwnam);
not_implemented!(getpwuid_r);
not_implemented!(getpwnam_r);
not_implemented!(gethostbyname);
not_implemented!(execv);
not_implemented!(execvp);
not_implemented!(execvpe);
not_implemented!(wordexp);

/// See [rustix-openpty](https://github.com/sunfishcode/rustix-openpty).
pub fn closefrom() {
unimplemented!()
}
/// See [rustix-openpty](https://github.com/sunfishcode/rustix-openpty).
pub fn login_tty() {
unimplemented!()
}
/// See [rustix-openpty](https://github.com/sunfishcode/rustix-openpty).
pub fn openpty() {
unimplemented!()
}

/// See [`std::io::IsTerminal`].
///
/// For Rust < 1.70, see [is-terminal]. For a rustix-based implementation,
/// see [rustix-is-terminal].
///
/// [`std::io::IsTerminal`]: https://doc.rust-lang.org/stable/std/io/trait.IsTerminal.html
/// [is-terminal]: https://crates.io/crates/is-terminal
/// [rustix-is-terminal]: https://github.com/sunfishcode/rustix-is-terminal
pub fn isatty() {
unimplemented!()
}
}

/// These functions are not yet implemented in rustix, but probably could be.
///
/// These are functions that users have asked about, and which probably are
/// in scope for rustix, but are not yet implemented. This module contains an
/// incomplete list of such functions.
pub mod yet {
not_implemented!(tgkill);
not_implemented!(raise);
not_implemented!(sysctl);
not_implemented!(mq_open);
not_implemented!(mq_send);
not_implemented!(mq_unlink);
not_implemented!(recvmmsg);
not_implemented!(cachestat);
not_implemented!(fanotify_init);
not_implemented!(fanotify_mark);
not_implemented!(getifaddrs);
not_implemented!(signalfd);
not_implemented!(pidfd_send_signal);
not_implemented!(mount_setattr);
not_implemented!(extattr_delete_fd);
not_implemented!(extattr_delete_link);
not_implemented!(extattr_get_fd);
not_implemented!(extattr_get_link);
not_implemented!(extattr_list_fd);
not_implemented!(extattr_list_link);
not_implemented!(extattr_set_fd);
not_implemented!(extattr_set_link);
not_implemented!(get_mempolicy);
not_implemented!(mbind);
not_implemented!(set_mempolicy);
not_implemented!(migrate_pages);
not_implemented!(move_pages);
not_implemented!(fchmodat2);
not_implemented!(shmat);
not_implemented!(shmdt);
not_implemented!(shmget);
not_implemented!(shmctl);
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signal handling functions in this list (tgkill, raise, signalfd, pidfd_send_signal) belong in the "awkward to provide this without interfering with the system C library" list.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These might be ok. It's generally ok to raise signals, because libc's alreaedy have to accept that signals can get raised from outside the process too. We may want to gate them behind cfg(feature = "use-libc-sigrt") and reject reserved signal values though. Or make them unsafe with a safety condition of "don't use reserved signals, on penalty of UB".

Copy link
Copy Markdown
Member Author

@sunfishcode sunfishcode Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you also mentioned signalfd here. We should think about reserved signals there also, but otherwise, since it doesn't involve actual handlers, it might be ok.


/// These functions are not yet finished in rustix.
///
/// Rustix's codebase includes experimental implementations of these functions,
/// however they are not yet publicly exposed because their API might need more
/// work and/or they don't yet have a libc backend implementation.
///
/// See [#1314] for more information, and please leave comments if there are
/// specific functions you're interested in.
///
/// [#1314]: https://github.com/bytecodealliance/rustix/issues/1314
pub mod quite_yet {
not_implemented!(_exit);
not_implemented!(_Exit);
not_implemented!(exit_group);
not_implemented!(sigpending);
not_implemented!(sigsuspend);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here re sigpending and sigsuspend

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tentatively categorized sigpending and sigsuspend as things we may be able to do, because they don't interfere with any signal handlers. But I guess this is all why I inserted some "probably"s into the comments. I haven't thought about all these super deeply yet.

not_implemented!(execveat);
not_implemented!(execve);

/// For now, use `rustix::process::uname().nodename()` instead.
///
/// See also the [module comment](self).
pub fn gethostname() {
unimplemented!()
}
}
Loading