Add support for renameat_with on Apple platforms#1340
Merged
sunfishcode merged 1 commit intobytecodealliance:mainfrom Feb 22, 2025
Merged
Add support for renameat_with on Apple platforms#1340sunfishcode merged 1 commit intobytecodealliance:mainfrom
renameat_with on Apple platforms#1340sunfishcode merged 1 commit intobytecodealliance:mainfrom
Conversation
Contributor
Author
|
Testing wise... I do not have a mac. I'm adding support here so I can use it in |
Stebalien
force-pushed
the
steb/renameat-apple
branch
4 times, most recently
from
8c4d77a to
1acff62
Compare
Apple platforms (both iOS and macOS) added a `renameat2` equivalent in 10.12 (and the iOS equivalent). This patch uses that syscall to implement `renameat2`, and subsequently `renameat_with`. Unlike Linux, the `RenameFlags::WHITEOUT` flag isn't supported. At the moment, any programs trying to use that flag will fail to compile on Apple operating systems.
Stebalien
force-pushed
the
steb/renameat-apple
branch
from
1acff62 to
41b82b5
Compare
Member
|
Looks like the CI is happy with it. Thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apple platforms (both iOS and macOS) added a
renameat2equivalent in 10.12 (and the iOS equivalent). This patch uses that syscall to implementrenameat2, and subsequentlyrenameat_with.Unlike Linux, the
RenameFlags::WHITEOUTflag isn't supported. At the moment, any programs trying to use that flag will fail to compile on Apple operating systems.