Rename some runtime functions to kernel_*.#1342
Merged
sunfishcode merged 1 commit intomainfrom Feb 21, 2025
Merged
Conversation
To help avoid confusion with functions that have the same name as libc functions but have behavior that differs from similarly-named libc functions, rename `runtime::fork` and similar to `runtime::kernel_fork` and similar. Also rename types such as `Sigaction` and similar to `KernelSigaction` and similar. And rename `SIGRTMIN`/`SIGRTMAX` to `KERNEL_SIGRTMIN`/`KERNEL_SIGRTMAX`. These make it easier to keep these are the kernel items straight from the similarly-named libc structures.
Member
Author
|
For example, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help avoid confusion with functions that have the same name as libc functions but have behavior that differs from similarly-named libc functions, rename
runtime::forkand similar toruntime::kernel_forkand similar. Also rename types such asSigactionand similar toKernelSigactionand similar. And renameSIGRTMIN/SIGRTMAXtoKERNEL_SIGRTMIN/KERNEL_SIGRTMAX.These make it easier to keep these are the kernel items straight from the similarly-named libc structures.