Fix I/O safety in io_uring_setup and configure_virtual_memory_map#1351
Merged
sunfishcode merged 2 commits intomainfrom Feb 24, 2025
Merged
Fix I/O safety in io_uring_setup and configure_virtual_memory_map#1351sunfishcode merged 2 commits intomainfrom
io_uring_setup and configure_virtual_memory_map#1351sunfishcode merged 2 commits intomainfrom
Conversation
Use `RawFd` for fd parameters in `PrctlMmMap` and `io_uring_params`, and make functions that take them as arguments `unsafe` to reflect that they depend on any file descriptors being valid. Fixes #1001.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
RawFdfor fd parameters inPrctlMmMapandio_uring_params, and make functions that take them as argumentsunsafeto reflect that they depend on any file descriptors being valid.Fixes #1001.