Merged
Conversation
This fixes a bug where a duplicate import might occur when an import with dependencies on other interfaces is encoded and then later on an import for one of those dependencies is also explicitly encoded. It skips the import if it has already been imported and also ensures that the full interface definition is provided when encoding at the root state (i.e. for the composition itself and not an instance/component type). As such, we don't need to process dependencies of implicit imports during resolution.
peterhuene
force-pushed
the
fix-encoding
branch
from
caec35b to
01c0828
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where a duplicate import might occur when an import with dependencies on other interfaces is encoded and then later on an import for one of those dependencies is also explicitly encoded.
It skips the import if it has already been imported and also ensures that the full interface definition is provided when encoding at the root state (i.e. for the composition itself and not an instance/component type).
As such, we don't need to process dependencies of implicit imports during resolution.