Merged
Conversation
This commit fixes encoding of used types such that renamed types now properly encode. Used types are now stored in a map from export/import name to used interface (along with the original export name when renamed). Additionally, `todo!` placeholders were added for merging non-interface imports, which will be needed in the near future. Also removed some redundant code in package decoding and improved the debug log output of the local package resolver.
fibonacci1729
approved these changes
Dec 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes encoding of used types such that renamed types now properly encode.
Used types are now stored in a map from export/import name to used interface (along with the original export name when renamed).
Additionally,
todo!placeholders were added for merging non-interface imports, which will be needed in the near future.Also removed some redundant code in package decoding and improved the debug log output of the local package resolver.