Merged
Conversation
This commit improves the subtype checking logic and the error messages it produces. It fixes a bug where the `targets` check was not properly performing checks against imports, which should be contravariant. Also fixes a warning relating to a deprecated function call; the fix is to not remove from the collection as we no longer have to since the bytes of a package are behind an `Arc`.
rylev
approved these changes
Feb 12, 2024
fibonacci1729
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the subtype checking logic and the error messages it produces.
It fixes a bug where the
targetscheck was not properly performing checks against imports, which should be contravariant.Also fixes a warning relating to a deprecated function call; the fix is to not remove from the collection as we no longer have to since the bytes of a package are behind an
Arc.Additionally, fixes a bug in calculating of spans relating to expressions with postfix operations; incorrect length calculations would cause a panic when formatting errors with those spans.