Implement let statement resolution.#6
Merged
peterhuene merged 1 commit intomainfrom Nov 1, 2023
Merged
Conversation
This commit implements let-statement resolution, which includes: * Resolution of new expressions. * Resolution of access expressions. The resolution of new expressions is complicated as it has to perform type checks for the instantiation arguments; the logic of which is in the newly implemented `SubtypeChecker`, which operates solely off of WAC type information. Resolution now stores resolved "items" that have information attached about where they were sourced from (i.e. an import statement, an instantiation, etc.). Type information has been refactored (again, sorry) to hopefully make more sense and appear better in error messages. Additionally, the grammar was updated to support named instantiation arguments by identifier (and not just by strings). Error reporting has also been cleaned up to remove duplicated information. To support testing, a default `wat` feature allows for parsing component dependencies from local `wat` files. The CLI now supports passing the paths to known package dependencies (via the `--dep` option).
Member
Author
|
@fibonacci1729 no rush on the review! With this, I'll have another big PR coming to move us away from pest and one much, much smaller PR to finish resolution so that we can finally encode output components! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements let-statement resolution, which includes:
The resolution of new expressions is complicated as it has to perform type checks for the instantiation arguments; the logic of which is in the newly implemented
SubtypeChecker, which operates solely off of WAC type information.Resolution now stores resolved "items" that have information attached about where they were sourced from (i.e. an import statement, an instantiation, etc.).
Type information has been refactored (again, sorry) to hopefully make more sense and appear better in error messages.
Additionally, the grammar was updated to support named instantiation arguments by identifier (and not just by strings).
Error reporting has also been cleaned up to remove duplicated information.
To support testing, a default
watfeature allows for parsing component dependencies from localwatfiles.The CLI now supports passing the paths to known package dependencies (via the
--depoption).