Find defined type id used in remapping in ItemKind::Type#64
Merged
peterhuene merged 1 commit intobytecodealliance:apifrom Apr 4, 2024
Merged
Find defined type id used in remapping in ItemKind::Type#64peterhuene merged 1 commit intobytecodealliance:apifrom
ItemKind::Type#64peterhuene merged 1 commit intobytecodealliance:apifrom
Conversation
Signed-off-by: Ryan Levick <ryan.levick@fermyon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was running into a panic
expected a defined typewhere thekindwas aItemKind::Type(Type::Value(ValueType::Defined(_))).It seems that at the end of
remap_defined_type, we're insertingItemKind::Type(Type::Value(ValueType::Defined(id)))into the aggregated map and so we should always expect to get these defined types with aItemKind::Type(Type::Value(ValueType::Defined(_)))key.This does seem to fix the issue though I'm not sure what the consequences if any of always storing things as
ItemKind:::Typevs.ItemKind::Value.