Merged
Conversation
This commit fixes aggregation of imports that have used types. Previously, interfaces weren't being coalesced properly, resulting in duplicate imports of used interfaces that would result in an encoding validation error. The fix is to coalesce interfaces by interface identifier, merging interfaces together during the remapping process. Additionally, this fixes a bug in encoding where any implicitly imported instances were not getting their encoded indexes recorded in the encoding state properly. Also changed the map in the type aggregator to store `Type`s rather than `ItemKind`s, which makes things neater. Fixes #65.
rylev
approved these changes
Apr 6, 2024
Collaborator
rylev
left a comment
rylev
left a comment
There was a problem hiding this comment.
Just a few tiny nits. Looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes aggregation of imports that have used types.
Previously, interfaces weren't being coalesced properly, resulting in duplicate imports of used interfaces that would result in an encoding validation error.
The fix is to coalesce interfaces by interface identifier, merging interfaces together during the remapping process.
Additionally, this fixes a bug in encoding where any implicitly imported instances were not getting their encoded indexes recorded in the encoding state properly.
Also changed the map in the type aggregator to store
Types rather thanItemKinds, which makes things neater.Fixes #65.