Add a package declaration to the grammar. #9
Merged
peterhuene merged 1 commit intomainfrom Nov 7, 2023
Merged
Conversation
fibonacci1729
approved these changes
Nov 7, 2023
This commit adds a `package` directive to the grammar to match what is present in WIT. As a result, the `--package` command line argument to the `parse` command was removed. Additionally, lexing of semver is relaxed so that invalid semantic versions can be detected when building the AST.
peterhuene
force-pushed
the
package-directive
branch
from
8d22fe4 to
d69a3ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
packagedirective to the grammar to match what is presentin WIT.
As a result, the
--packagecommand line argument to theparsecommand wasremoved.
Additionally, lexing of semver is relaxed so that invalid semantic versions can
be detected when building the AST.