This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Update WIT in tests with async#132
Merged
Merged
Conversation
alexcrichton
force-pushed
the
more-async
branch
from
8ecde5a to
8b6c750
Compare
This commit updates the WIT used in test to use the `async` keyword and generally try to avoid manually configuring what's async and what's not in the guest. This does not update the host's handling of the `async` keyword in WIT for `wasmtime::component::bindgen!`. Some assorted bindgen issues were fixed here and there and WASI WITs were updated as well with `async` where it seemed appropriate. I'll note that there are some usages of concurrent imports when there's no actual concurrency, it's just there for getting an `Accessor` and, for example, spawning tasks. In these situations we may want to explore possible modes of bindings generation on the host side of things which avoids the need for manual configuration. Coupled with bytecodealliance/wit-bindgen#1278 and bytecodealliance/wit-bindgen#1279.
alexcrichton
force-pushed
the
more-async
branch
from
8b6c750 to
2ed1686
Compare
Our pinned version is pretty out-of-date and seems like it's having difficulty parsing more recent Cargo syntax in the wasip3-prototyping fork.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coupled with bytecodealliance/wit-bindgen#1278