This repository was archived by the owner on Sep 8, 2025. It is now read-only.
Well, I thought I was done for today#197
Merged
Merged
Conversation
* Add a test for reproducing #10906 This also includes a compile test; the disassembly makes things more clear. * Fix #10906 by zeroing the XMM register prior to use
This commit synchronizes the list of intrinsics and notably libcalls with the wasip3-prototyping repository. This change alone does not really do all that much but the goal is to reduce the diff between this repository and the wasip3-prototyping repository. The main change included here is synchronizing the list of libcalls. That necessitates changing various concrete signatures of libcalls and all implementations are replaced with `todo!()` for now to get filled in in the future. Additionally this necessitates changes to the trampoline compilation as well which is brought wholesale from the wasip3-prototyping repository. Note that this should all be well-tested and covered in the wasip3-prototyping repository so no extra tests are brought in at this time. The intention is that once the runtime bits start landing here upstream it'll be accompanied with appropriate tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But apparently not. It's ok I'm also trying to learn how to manage a fork and gradual upstreaming. Apologies to the noise for everyone else...