nuttx: Add missing pthread.h header#2009
Merged
wenyongh merged 1 commit intobytecodealliance:mainfrom Mar 7, 2023
Merged
Conversation
Contributor
Author
|
@no1wudi CI build for NuttX seems to be broken after apache/nuttx-apps#1609 got merged. |
Collaborator
I'll submit a fix today. |
no1wudi
approved these changes
Mar 7, 2023
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
a2ec41c to
2c31a61
Compare
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intends to add the missing
pthread.hheader to the NuttX build to fix the following build error:In file included from wamr/core/shared/utils/../platform/include/platform_common.h:13, from wamr/core/shared/utils/bh_platform.h:9, from wamr/core/iwasm/aot/aot_runtime.h:9, from wamr/core/iwasm/aot/aot_loader.c:6: wamr/core/shared/platform/nuttx/platform_internal.h:39:9: error: unknown type name 'pthread_t' typedef pthread_t korp_tid; ^~~~~~~~~ wamr/core/shared/platform/nuttx/platform_internal.h:40:9: error: unknown type name 'pthread_mutex_t' typedef pthread_mutex_t korp_mutex; ^~~~~~~~~~~~~~~ wamr/core/shared/platform/nuttx/platform_internal.h:41:9: error: unknown type name 'pthread_cond_t' typedef pthread_cond_t korp_cond; ^~~~~~~~~~~~~~ wamr/core/shared/platform/nuttx/platform_internal.h:42:9: error: unknown type name 'pthread_t' typedef pthread_t korp_thread; ^~~~~~~~~ In file included from wamr/core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/posix.h:18, from wamr/core/iwasm/aot/../common/wasm_runtime_common.h:18, from wamr/core/iwasm/aot/aot_runtime.h:10, from wamr/core/iwasm/aot/aot_loader.c:6: wamr/core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/locking.h:52:5: error: unknown type name 'pthread_mutex_t' pthread_mutex_t object; ^~~~~~~~~~~~~~~ wamr/core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/locking.h:87:5: error: unknown type name 'pthread_rwlock_t' pthread_rwlock_t object; ^~~~~~~~~~~~~~~~ wamr/core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/locking.h:123:5: error: unknown type name 'pthread_cond_t' pthread_cond_t object; ^~~~~~~~~~~~~~ wamr/core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/locking.h: In function 'cond_init_monotonic': wamr/core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/locking.h:135:5: error: unknown type name 'pthread_condattr_t' pthread_condattr_t attr; ^~~~~~~~~~~~~~~~~~ make[3]: *** [/home/nihei/Projects/NuttX/apps/Application.mk:157: aot_loader.c.home.nihei.Projects.NuttX.apps.interpreters.wamr.o] Error 1