fix os_socket_addr_resolve() for IPv6#2015
Merged
wenyongh merged 1 commit intobytecodealliance:mainfrom Mar 7, 2023
Merged
Conversation
The function always specified IPv4 socklen to sockaddr_to_bh_sockaddr(), therefore the assertion was failing; however, sockaddr_to_bh_sockaddr() never actually used socklen parameter, so we deleted it completely.
hritikgupta
approved these changes
Mar 7, 2023
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
The function always specified IPv4 socklen to sockaddr_to_bh_sockaddr(), therefore the assertion was failing; however, sockaddr_to_bh_sockaddr() never actually used socklen parameter, so we deleted it completely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function always specified IPv4 socklen to sockaddr_to_bh_sockaddr(),
therefore the assertion was failing; however, sockaddr_to_bh_sockaddr()
never actually used socklen parameter, so we delete it completely.