Fix another integer overflow in wasmprinter's nesting#123
Merged
Conversation
Don't decrease the current nesting level past where we started in the case that there's multiple `end` instructions.
alexcrichton
force-pushed
the
fix-overflow
branch
from
d36c2b7 to
5bf5d9d
Compare
fitzgen
approved these changes
Oct 21, 2020
dhil
added a commit
to dhil/wasm-tools
that referenced
this pull request
Aug 2, 2024
This patch changes the syntax of resume tables to match that of the reference interpreter, i.e. ```wast resume $ct (tag $t $h)* => resume $ct (on $t $h)* resume_throw $ct $e (tag $t $h)* => resume $ct $e (on $t $h)* ``` I have also updated the testsuite (by simply copying in the `cont.wast` from the reference interpreter). In doing so, I stumbled upon a bug in the wellformedness check for continuation types for which I have also included a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't decrease the current nesting level past where we started in the
case that there's multiple
endinstructions.