Gate WebAssembly validation behind a new 'validate' feature#1532
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom May 6, 2024
Merged
Gate WebAssembly validation behind a new 'validate' feature#1532alexcrichton merged 2 commits intobytecodealliance:mainfrom
alexcrichton merged 2 commits intobytecodealliance:mainfrom
Conversation
This commit moves all of the validation logic of `wasmparser` behind a new Cargo features named `validate`. This cuts down the dependency tree for users who only need to parse wasm files. For example `wasmprinter` doesn't need to validate, it only needs to parse. Closes bytecodealliance#1528
Member
Author
pchickey
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit moves all of the validation logic of
wasmparserbehind a new Cargo features namedvalidate. This cuts down the dependency tree for users who only need to parse wasm files. For examplewasmprinterdoesn't need to validate, it only needs to parse.Closes #1528