Add manifest metadata for cargo binstall#1562
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom May 16, 2024
Merged
Add manifest metadata for cargo binstall#1562alexcrichton merged 1 commit intobytecodealliance:mainfrom
cargo binstall#1562alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
I've seen this recommended a number of times for installing precompiled binaries and this enables `cargo binstall` to pull from the precompiled artifacts produced on CI rather than needing a third-party source.
Member
Author
|
I've tested this out a bit over on wasm-component-ld and it seems to work well there so copying over here too. |
pchickey
approved these changes
May 16, 2024
alexcrichton
added a commit
to alexcrichton/wasmtime
that referenced
this pull request
May 22, 2024
This was pioneered in bytecodealliance/wasm-tools#1562 and looks to be working well so I've copied over similar metadata for Wasmtime. I've seen the `cargo binstall` method of installing binaries to be somewhat common and we've already got all the necessary binaries so it seemed nice to add support. Wasmtime doesn't name the artifacts after Rust target names so some manual configuration is required here, but otherwise this hopefully isn't too costly to maintain.
github-merge-queue Bot
pushed a commit
to bytecodealliance/wasmtime
that referenced
this pull request
May 22, 2024
This was pioneered in bytecodealliance/wasm-tools#1562 and looks to be working well so I've copied over similar metadata for Wasmtime. I've seen the `cargo binstall` method of installing binaries to be somewhat common and we've already got all the necessary binaries so it seemed nice to add support. Wasmtime doesn't name the artifacts after Rust target names so some manual configuration is required here, but otherwise this hopefully isn't too costly to maintain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've seen this recommended a number of times for installing precompiled binaries and this enables
cargo binstallto pull from the precompiled artifacts produced on CI rather than needing a third-party source.