Minor updates to the playground#1605
Merged
fitzgen merged 8 commits intobytecodealliance:mainfrom Jun 11, 2024
Merged
Conversation
Use a relative link instead of an absolute one to handle hosting on different roots
Make it a bit more descriptive which workflow they're attached to with just the name of the job
Exclude the crate from testing to avoid building it on other targets.
Inherit the default settings for now and if distribution of the wasm is a problem it can be re-added on a per-CI-job-basis.
fitzgen
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few misc things noticed testing out online and building locally too