Initialize a test suite for wit-encoder#1626
Merged
alexcrichton merged 13 commits intobytecodealliance:mainfrom Jun 20, 2024
Merged
Initialize a test suite for wit-encoder#1626alexcrichton merged 13 commits intobytecodealliance:mainfrom
wit-encoder#1626alexcrichton merged 13 commits intobytecodealliance:mainfrom
Conversation
Member
Author
|
lmao, what in the Windows line-endings: |
573bcd7 to
b7332a2
Compare
Rebasing brok
b7332a2 to
43cc254
Compare
Member
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! I think if the files are included in the source files rather than as separate files that may also fix the line endings issue. Also for landing mind leaving out the WIT files that aren't yet tested?
alexcrichton
approved these changes
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1549 and #1580, this begins adding a test suite for
wit-encoder. Specifically: this takes the tests fromwit-parser, and then tries to encode those in individual tests. It fixes a number of bugs, as well as adds support forincludestatements. It also changes the default indentation for WIT documents to2, which matches the style that's been used in the WIT spec and WASI documents.Not all
.witfiles have their own tests yet. But I ran out of time before I could finish up all the tests, but I figured even a partial test suite would already be a useful contribution. Thanks!