threads: check mutability of GC instructions#1729
Merged
alexcrichton merged 5 commits intobytecodealliance:mainfrom Aug 21, 2024
Merged
threads: check mutability of GC instructions#1729alexcrichton merged 5 commits intobytecodealliance:mainfrom
alexcrichton merged 5 commits intobytecodealliance:mainfrom
Conversation
Previously this was not being checked; this adds tests which force new validation logic.
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! Could these checks perhaps be encapsulated in helpers? Something like self.mutable_struct_field_at(...) instead of self.struct_field_at(...) plus a check?
alexcrichton
approved these changes
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds logic and tests to check that
struct|array.atomic.rmw.*instructions cannot modify GC objects unless they're marked as mutable.