Skip to content

Enable bulk-memory and reference-types by default#209

Merged
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
alexcrichton:enable-default-features
Jan 26, 2021
Merged

Enable bulk-memory and reference-types by default#209
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
alexcrichton:enable-default-features

Conversation

@alexcrichton

Copy link
Copy Markdown
Member

These proposals moved to stage 4 some time ago, so enable them by
default in the validator.

@alexcrichton alexcrichton requested a review from fitzgen January 25, 2021 18:55

@fitzgen fitzgen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any docs need updating as well? r=me with those (if needed) too

These proposals moved to stage 4 some time ago, so enable them by
default in the validator.
@alexcrichton alexcrichton force-pushed the enable-default-features branch from a49ab3e to ea9837b Compare January 26, 2021 15:12
@alexcrichton alexcrichton merged commit 176c9da into bytecodealliance:main Jan 26, 2021
@alexcrichton alexcrichton deleted the enable-default-features branch January 26, 2021 15:12
alexcrichton added a commit to alexcrichton/wasm-tools that referenced this pull request Nov 16, 2022
* Split out the `flags` type from `record`

This commit creates a dedicated `flags` type which is distinct from the
`record` type rather than the previous inferred-from-the-structure
logic. This also additionally changes the canonical ABI of the `flags`
type where 64-bit flags are now passed as two `i32` values instead of
one `i64`. This ended up changing a significant amount of the logic
internally in each code generator, notably around the new lift/lower
behavior.

Along the way I tried to refactor code to support 64+ flags in a few
more places. While some support may be there, though, this is untested
and will need a full-fledged feature in the future.

* Fix a test

* Fix some more flags

* Fix more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants