Fix validation of atomic mutation of shared globals#2473
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Mar 31, 2026
Merged
Conversation
This commit updates validation of atomic-related mutation instructions, only applicable with the shared-everything-threads proposal, to require that the global in question is flagged as mutable. This seems like an oversight in the current implementation, so mutability is required for now.
pchickey
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates validation of atomic-related mutation instructions, only applicable with the shared-everything-threads proposal, to require that the global in question is flagged as mutable. This seems like an oversight in the current implementation, so mutability is required for now.