Skip to content

wasmparser: Rename BinaryReaderError to Error#2546

Merged
alexcrichton merged 3 commits into
bytecodealliance:mainfrom
lann:wasmparser-rename-error
Jun 29, 2026
Merged

wasmparser: Rename BinaryReaderError to Error#2546
alexcrichton merged 3 commits into
bytecodealliance:mainfrom
lann:wasmparser-rename-error

Conversation

@lann

@lann lann commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This type hasn't been particularly BinaryReader-specific for a long time, being returned by e.g. Validator which can be used without any direct use of a BinaryReader.

  • Move crate::binary_reader::BinaryReaderError to crate::error::Error
  • Add crate::BianryReaderError type alias for backward compatibility
  • Update references in other workspace crates

@lann lann requested a review from a team as a code owner June 26, 2026 19:40
@lann lann requested review from dicej and removed request for a team June 26, 2026 19:40
@lann

lann commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

I could easily be convinced that this should be e.g. ParserError instead. This is just a side quest on the way toward exposing details about WasmFeatures validation errors.

@alexcrichton alexcrichton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a cleanup I've wanted to see in the past myself as well, and I think Error is fine given how it's The Error for the crate. Thanks!

@alexcrichton alexcrichton added this pull request to the merge queue Jun 29, 2026
Merged via the queue into bytecodealliance:main with commit b6a4a4a Jun 29, 2026
37 checks passed
@lann lann deleted the wasmparser-rename-error branch June 29, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants