Add CustomSectionReader -> BinaryReader conversion#2550
Merged
alexcrichton merged 1 commit intoJun 30, 2026
Conversation
Construction by hand does not preserve features of the parser.
This also shrinks the parser to the remaining data.
Passing it in the enum as a field of KnownCustom::Unknown would
break consumers. The recommended approach is thus to use it as
match custom.name() {
"my-interesting-custom-section" => foo(custom.data_reader()),
_ => {},
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Construction by hand does not preserve features field of the parser.
This also shrinks the parser to the remaining data. Passing the reader as a field of
KnownCustom::Unknownwould break consumers, hence this is a standalone method here. The recommended approach is thus to use it as