Add SourceMap::resolve_span for resolving global span locations#2559
Merged
Conversation
PhoebeSzmucer
commented
Jul 7, 2026
| /// | ||
| /// Spans pointing at the end of a file resolve to an empty range at the | ||
| /// file's length. | ||
| pub fn resolve_span(&self, span: Span) -> Option<SpanLocation<'_>> { |
Contributor
Author
There was a problem hiding this comment.
This LSP will call this method for spans that we get from structured errors.
alexcrichton
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
SourceMap::resolve_span(Span) -> Option<SpanLocation>, which resolves a global span to its source file and a file-local byte range. This makes it possible for consumers of wit-parser to get precise error locations.