wasm-mutate: Fix generating duplicate export names#455
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Jan 25, 2022
Merged
wasm-mutate: Fix generating duplicate export names#455alexcrichton merged 2 commits intobytecodealliance:mainfrom
alexcrichton merged 2 commits intobytecodealliance:mainfrom
Conversation
This fixes an issue from bytecodealliance#447 where the renaming export pass was mistakenly generating a duplicate export name because I forgot to add a check. The check is added here, however!
fitzgen
approved these changes
Jan 24, 2022
* Consume fuel when generating random names. * Also allow generating the same name as before, notably the empty name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue from #447 where the renaming export pass was
mistakenly generating a duplicate export name because I forgot to add a
check. The check is added here, however!