Split contribution instructions out to CONTRIBUTING.md #38
Conversation
Also update the set up and testing instructions.
CONTRIBUTING.md
Outdated
| So far this extension has been written by folks who are primarily Rust | ||
| programmers, so it's highly likely that there's some faux pas in terms of Python | ||
| idioms. Feel free to create a PR to help make things more idiomatic if you see | ||
| something! |
There was a problem hiding this comment.
I'm pretty sure that by this point, this extension does qualify as "idiomatic Python"!
There was a problem hiding this comment.
Heh yeah I'm happy to remove this clause if its unnecessary now (I'm also not really in a position to judge whether this package is idiomatic or not 😅 )
There was a problem hiding this comment.
I'm sure there are a few things that could be further improved, but Python packages aren't all that consistent in general. Wasmtime-py seems at the very least better than average to me, which means the warning no longer applies!
|
I've pushep up a few wording tweaks which makes the ask for help on idioms a bit less zealous (but still there because I'm paranoid), and I've also freshened up the instructions for handling the native lib. |
3 participants
Also update the set up and testing instructions.