Add support for configuring the engine's target#157
Merged
Conversation
Co-authored-by: Matt Rose <matt.rose@shopify.com>
jbourassa
approved these changes
Mar 24, 2023
|
|
||
| - name: Run ruby tests (hard-mode with GC.stress) | ||
| run: bundle exec rake spec | ||
| if: matrix.os != 'macos-latest' # these specs are aborting on CI with no logs, maybe OOM killer? |
Collaborator
There was a problem hiding this comment.
#156 is why it's aborting on macOS. Skipping meanwhile is fine by me, but I really want to fix that.
Collaborator
Author
There was a problem hiding this comment.
Good call. We'll re-enable after the fix is in.
| end | ||
|
|
||
| at_exit { GC.start(full_mark: true) } | ||
| at_exit { GC.start(full_mark: true) } if ENV["GC_AT_EXIT"] == "1" |
Collaborator
There was a problem hiding this comment.
Can you expand on your rationale behind this change?
Collaborator
Author
There was a problem hiding this comment.
It's really only necessary for valgrind, since Ruby might not free everything at exit otherwise from what I gather. Stole it from nokogiri.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will all users to cross-compile modules for various architectures. On top of that, it provides a mechanism to use a generic CPU architecture that doesn't make use of the native CPU features (i.e. if your servers use a mix of old and new
x86_64chips).