Fix potential GC bug when expiring the caller#162
Merged
saulecabrera merged 1 commit intomainfrom Mar 31, 2023
Merged
Conversation
The compiler may not keep the Caller's VALUE on the stack as we're not using it explicitly. Object allocations can thus cause the Caller to get GC'd, resulting in a segfault when we later try to `expire` it. Fixes #156
saulecabrera
approved these changes
Mar 31, 2023
Member
|
Great investigation! Thanks @jbourassa and @ianks! Regarding #158, I think it's still worth moving on with some parts of that change? e.g. implementing |
Collaborator
Author
Yes, I want to dive deeper into those 2 changes. I think marking the exception is unnecessary. Now that this pesky segfault is behind us, I'll look into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler may not keep the Caller's VALUE on the stack as we're not using it explicitly. Object allocations can thus cause the Caller to get GC'd, resulting in a segfault when we later try to
expireit.See #156 (comment) and #158 for investigation.
Fixes #156