Forward compatibility with future version of Magnus#172
Merged
jbourassa merged 7 commits intobytecodealliance:mainfrom Apr 8, 2023
Merged
Forward compatibility with future version of Magnus#172jbourassa merged 7 commits intobytecodealliance:mainfrom
jbourassa merged 7 commits intobytecodealliance:mainfrom
Conversation
will be removed in future version of Magnus
other methods will be going away in future version of Magnus
val.try_convert::<T>() won't be supported in future versions of magnus
magnus' prelude only imports traits, and imports them anonymously so is unlikely to cause issues
Symbol won't deref to Value in next version of magnus, so won't pick up the impl of ToValType for Value
jbourassa
approved these changes
Apr 8, 2023
Collaborator
Very appreciated as always. Thanks Mat! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, as I mentioned before I've been testing out Magnus API changes against this library to see how things feel in a real project.
This PR collects a handful of changes that will be required with the next major release of Magnus, but can be applied now (I did do a sneaky backport of a couple of very small things to fit them in here).